Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[web] Set initial data in useTable's state #48930

Merged
merged 1 commit into from
Nov 19, 2024
Merged

[web] Set initial data in useTable's state #48930

merged 1 commit into from
Nov 19, 2024

Conversation

kiosion
Copy link
Contributor

@kiosion kiosion commented Nov 13, 2024 •
edited
Loading

Fix flickering to 'No data' state on Table's first render, before useTable's updateData useEffect fires.

Before / after

before
after

@kiosion kiosion added the no-changelog Indicates that a PR does not require a changelog entry label Nov 13, 2024
@github-actions github-actions bot requested review from kimlisa and rudream November 13, 2024 20:27
@kiosion kiosion force-pushed the maxim/use-table-init branch 2 times, most recently from f2782ce to 9732a3f Compare November 14, 2024 02:26
@kiosion
fix: Set initial data in useTable state
9a0951d 
* Fix flickering between 'No data' state on first render, before
  `updateData` useEffect fires.
@kiosion kiosion force-pushed the maxim/use-table-init branch from 9732a3f to 9a0951d Compare November 15, 2024 19:42
@kiosion kiosion requested a review from kimlisa November 15, 2024 21:58
@r0mant r0mant requested review from avatus and removed request for kimlisa November 18, 2024 19:49
avatus
avatus approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, works great. Finally get rid of that silly flicker! It even happened on purely client side data too, which always made me mad

@kiosion kiosion added this pull request to the merge queue Nov 19, 2024
Merged via the queue into master with commit d0ed809 Nov 19, 2024
39 checks passed
@kiosion kiosion deleted the maxim/use-table-init branch November 19, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimlisa kimlisa kimlisa left review comments

@rudream rudream rudream approved these changes

@avatus avatus avatus approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kiosion @avatus @kimlisa @rudream