-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make msteams use common recipient with filled data field #48908
Open
EdwardDowling
wants to merge
4
commits into
master
Choose a base branch
from
edwarddowling/msteams-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change msteams to using the provided data field in the common recipient type to store extra required data.
EdwardDowling
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v17
labels
Nov 13, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
bernardjkim
approved these changes
Nov 14, 2024
Can we remove teleport/integrations/access/common/recipient.go Lines 153 to 160 in c9d3ce3
|
hugoShaka
approved these changes
Nov 15, 2024
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
November 15, 2024 18:27
tigrato
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change msteams to using the provided data field in the common recipient type to store extra required data.