Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make msteams use common recipient with filled data field #48908

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EdwardDowling
Copy link
Contributor

Change msteams to using the provided data field in the common recipient type to store extra required data.

Change msteams to using the provided data field in the common
recipient type to store extra required data.
@EdwardDowling EdwardDowling added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 13, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48908.d3pp5qlev8mo18.amplifyapp.com

integrations/access/msteams/bot.go Outdated Show resolved Hide resolved
@hugoShaka
Copy link
Contributor

Can we remove

// GetNames returns a slice of the recipient names in the set.
func (s *RecipientSet) GetNames() []string {
names := make([]string, 0, len(s.recipients))
for _, recipient := range s.recipients {
names = append(names, recipient.Name)
}
return names
}
as well?

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from tigrato November 15, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants