Add Contacts RBAC #48885
Merged
Add Contacts RBAC #48885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
probakowski
approved these changes
Nov 25, 2024
zmb3
reviewed
Nov 26, 2024
mcbattirola
added
the
no-changelog
Co-authored-by: Zac Bergquist <[email protected]>
…eleport into mcbattirola/contact-rbac
|
Update: I added this commit 11748df which adds |
…tirola/contact-rbac
zmb3
approved these changes
Dec 3, 2024
public-teleport-github-review-bot
bot
removed the request for review
from tcsc
mcbattirola
added a commit
that referenced
this pull request
Dec 9, 2024
* Add Contact resource; include it in default editor permissions and web ACL * Add contacts to ACL test * Improve godocs Co-authored-by: Zac Bergquist <[email protected]> * Add `contact` to the web user context --------- Co-authored-by: Zac Bergquist <[email protected]>
mcbattirola
added a commit
that referenced
this pull request
Dec 9, 2024
* Add Contact resource; include it in default editor permissions and web ACL * Add contacts to ACL test * Improve godocs Co-authored-by: Zac Bergquist <[email protected]> * Add `contact` to the web user context --------- Co-authored-by: Zac Bergquist <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Add Contact resource; include it in default editor permissions and web ACL * Add contacts to ACL test * Improve godocs * Add `contact` to the web user context --------- Co-authored-by: Zac Bergquist <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
* Add Contacts RBAC (#48885) * Add Contact resource; include it in default editor permissions and web ACL * Add contacts to ACL test * Improve godocs Co-authored-by: Zac Bergquist <[email protected]> * Add `contact` to the web user context --------- Co-authored-by: Zac Bergquist <[email protected]> * Fix merge conflict --------- Co-authored-by: Zac Bergquist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new type of resource,
contact, and gives read and write permissions to it to the defaulteditorrole.The permission is also added to the
UserACLobject that gets sent to the web UI.This value is unused for now, a future teleport.e PR will use it both in the UI (to display or hide sections of the screen) and in the Cloud API permission layer, to control who can list and edit Business and Security contacts.
This is part of https://github.com/gravitational/cloud/issues/10491
teleport.e PR using this new resource: https://github.com/gravitational/teleport.e/pull/5561
RFD: cloud/0157