Skip session data recording for networking requests #48868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
added
no-changelog
marcoandredinis
approved these changes
Nov 13, 2024
codingllama
reviewed
Nov 13, 2024
codingllama
reviewed
Nov 14, 2024
Joerger
force-pushed
the
joerger/skip-session-data-for-networking-requests
branch
from
66094dd to
c3ff32a
Compare
codingllama
approved these changes
Nov 14, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
Joerger
force-pushed
the
joerger/skip-session-data-for-networking-requests
branch
from
c3ff32a to
f4d1ddc
Compare
Joerger
deleted the
joerger/skip-session-data-for-networking-requests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new networking process for v17 inherited a small bug in the forwarding server context which causes a
session.dataaudit event with missing fields. This PR skips the audit event by setting recording mode to off, but a better long term solution would be to separate "connection", "command", and "server" contexts.ServerContextis just trying to do too much and isn't very reusable.Fixes #48728