[v17] Using discovery service poll_interval for access graph sync #48846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ryan Clark <[email protected]>
Co-authored-by: Tiago Silva <[email protected]>
r0mant
approved these changes
Nov 12, 2024
tigrato
approved these changes
Nov 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
mvbrock
added a commit
that referenced
this pull request
Nov 12, 2024
…8846) * Using discovery service poll_interval for access graph sync * Adding a new poll_interval field to access graph sync config * Update lib/srv/discovery/access_graph.go Co-authored-by: Ryan Clark <[email protected]> * Adding default poll interval * Make fix-imports * Updating derived functions for config * Apply suggestions from code review Co-authored-by: Tiago Silva <[email protected]> * Followup from PR comments * Applying protobuf tags to avoid conversion * Removing conversion * Regen grpc from rebase * Adding warning message and checking for nil config --------- Co-authored-by: Ryan Clark <[email protected]> Co-authored-by: Tiago Silva <[email protected]>
mvbrock
added a commit
that referenced
this pull request
Nov 12, 2024
…8846) * Using discovery service poll_interval for access graph sync * Adding a new poll_interval field to access graph sync config * Update lib/srv/discovery/access_graph.go Co-authored-by: Ryan Clark <[email protected]> * Adding default poll interval * Make fix-imports * Updating derived functions for config * Apply suggestions from code review Co-authored-by: Tiago Silva <[email protected]> * Followup from PR comments * Applying protobuf tags to avoid conversion * Removing conversion * Regen grpc from rebase * Adding warning message and checking for nil config --------- Co-authored-by: Ryan Clark <[email protected]> Co-authored-by: Tiago Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #48556 to branch/v17
changelog: The access graph poll interval is now configurable with the
discovery_service.poll_intervalfield, whereas before it was fixed to a 15 minute interval.