Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v17] RDS Discover flows: mention VPC instead of region #48827

Merged
merged 1 commit into from
Nov 13, 2024
Merged

[v17] RDS Discover flows: mention VPC instead of region #48827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions web/packages/teleport/src/Discover/Database/EnrollRdsDatabase/AutoDiscoverToggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,12 +38,12 @@ export function AutoDiscoverToggle({
disabled={disabled}
>
<Box ml={2} mr={1}>
Auto-enroll all databases for the selected region
Auto-enroll all databases for the selected VPC
</Box>
<ToolTipInfo>
Auto-enroll will automatically identify all RDS databases (e.g.
PostgreSQL, MySQL, Aurora) from the selected region and register them
as database resources in your infrastructure.
PostgreSQL, MySQL, Aurora) from the selected VPC and register them as
database resources in your infrastructure.
</ToolTipInfo>
</Toggle>
</Box>
Expand Down
2 changes: 1 addition & 1 deletion web/packages/teleport/src/Discover/Database/EnrollRdsDatabase/AutoEnrollment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ export function AutoEnrollment({
}
);

// Abort if there were no rds dbs for the selected region.
// Abort if there were no rds dbs for the selected region/vpc.
if (fetchedDbs.length <= 0) {
onFetchAttempt({ status: 'success' });
setTableData({ ...data, fetchStatus: 'disabled' });
Expand Down
2 changes: 1 addition & 1 deletion web/packages/teleport/src/Discover/Database/EnrollRdsDatabase/EnrollRdsDatabase.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ describe('test EnrollRdsDatabase.tsx', () => {
fireEvent.keyDown(selectEl, { key: 'ArrowDown' });
fireEvent.keyDown(selectEl, { key: 'Enter' });

await screen.findByText(/selected region/i);
await screen.findByText(/selected VPC/i);
}

test('without rds database result, does not attempt to fetch db servers', async () => {
Expand Down
2 changes: 1 addition & 1 deletion web/packages/teleport/src/Discover/Database/EnrollRdsDatabase/SingleEnrollment.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ export function SingleEnrollment({
}
);

// Abort early if there were no rds dbs for the selected region.
// Abort early if there were no rds dbs for the selected region/vpc.
if (fetchedDbs.length <= 0) {
onFetchAttempt({ status: 'success' });
setTableData({ ...data, fetchStatus: 'disabled' });
Expand Down
Loading