Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Docs: add discovery_group to teleport.yaml/discovery_service examples #48826

Merged
merged 3 commits into from
Nov 14, 2024

Conversation

marcoandredinis
Copy link
Contributor

Backport #48362 to branch/v16

When the discovery_group is not configured, teleport will log a warning
message saying that it is recommended.
Some configuration examples do not include it, so when users use that
example to implement their own variation, it will output a warning
message.
After seeing that warning users might wonder if there's anything wrong
with their `teleport.yaml`.
Instead, we add a discovery_group to all examples so that users don't
get that message.
@marcoandredinis marcoandredinis added the no-changelog Indicates that a PR does not require a changelog entry label Nov 12, 2024
@github-actions github-actions bot requested review from ptgott and r0mant November 12, 2024 17:48
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48826.d212ksyjt6y4yg.amplifyapp.com

Copy link

🤖 Vercel preview here: https://docs-hj10iletd-goteleport.vercel.app/docs/ver/preview

@marcoandredinis marcoandredinis added this pull request to the merge queue Nov 14, 2024
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from r0mant November 14, 2024 09:27
Merged via the queue into branch/v16 with commit 8913bdd Nov 14, 2024
43 checks passed
@marcoandredinis marcoandredinis deleted the bot/backport-48362-branch/v16 branch November 14, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants