Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add initial msteams hosted enroll docs #48756

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Add initial msteams hosted enroll docs #48756

merged 6 commits into from
Nov 15, 2024

Conversation

EdwardDowling
Copy link
Contributor

Part of #24495

Updates image showing hosted enrollment of plugins and adds some more info about msteams enrollment

@EdwardDowling EdwardDowling added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 11, 2024
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-181v9f3cy-goteleport.vercel.app/docs/ver/preview

r0mant
r0mant requested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The snippet you inserted is referring to Mattermost, not MS Teams. Screenshot from your rendered branch:

Screenshot 2024-11-11 at 11 31 37 AM

Also, should we mark some steps in the guide as optional when using a hosted version of the integration?

docs/pages/admin-guides/access-controls/access-request-plugins/ssh-approval-msteams.mdx Outdated Show resolved Hide resolved
@EdwardDowling @r0mant
Update docs/pages/admin-guides/access-controls/access-request-plugins…
291355d 
…/ssh-approval-msteams.mdx

Co-authored-by: Roman Tkachenko <[email protected]>
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-68vg4fruq-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-7y64nqa4q-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-4qlhanp99-goteleport.vercel.app/docs/ver/preview

@zmb3
Copy link
Collaborator

zmb3 commented Nov 13, 2024

Also note that the rendered docs say:

"on the left sidebar, click enroll new integration"

This text describes the v16 navigation, but the image shows the v17 navigation.

Can we fix the partial as part of this PR?

@EdwardDowling EdwardDowling force-pushed the edwarddowling/msteams-enroll-doc branch from 8877951 to 57b80e1 Compare November 14, 2024 16:46
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-3v9v9vgga-goteleport.vercel.app/docs/ver/preview

@EdwardDowling EdwardDowling force-pushed the edwarddowling/msteams-enroll-doc branch from 48d2c57 to 8cc7311 Compare November 14, 2024 17:09
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-11t7imufw-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-n0fe34g6o-goteleport.vercel.app/docs/ver/preview

r0mant
r0mant reviewed Nov 14, 2024
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EdwardDowling Two more comments regarding screenshots, then should be lgtm.

docs/img/enterprise/plugins/enroll.png Outdated Show resolved Hide resolved
docs/img/enterprise/plugins/msteams/enroll-bot.png Outdated Show resolved Hide resolved
@ptgott ptgott mentioned this pull request Nov 15, 2024
Closed
19 tasks
@EdwardDowling EdwardDowling force-pushed the edwarddowling/msteams-enroll-doc branch from 8cf0ef9 to dc0cecc Compare November 15, 2024 16:45
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-31nhdc8q4-goteleport.vercel.app/docs/ver/preview

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-6wbz1oomc-goteleport.vercel.app/docs/ver/preview

@r0mant r0mant added this pull request to the merge queue Nov 15, 2024
Merged via the queue into master with commit a7dd2bb Nov 15, 2024
39 of 40 checks passed
@r0mant r0mant deleted the edwarddowling/msteams-enroll-doc branch November 15, 2024 22:02
@public-teleport-github-review-bot
Copy link

@EdwardDowling See the table below for backport results.

Branch Result
branch/v17 Create PR

@r0mant r0mant mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmb3 zmb3 zmb3 approved these changes

@r0mant r0mant r0mant approved these changes

Assignees
No one assigned
Labels
backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EdwardDowling @zmb3 @r0mant