[entraid] store entra appId in plugin settings
#48754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This PR stores the Entra ID appID of the application used for SSO in Entra ID plugin settings. This field filled in a best effort scenario and might be empty for old Entra Plugins. Newly created plugins will make the field mandatory. Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/entra-id-expose-appid
branch
from
fe49e4b to
d29aeed
Compare
codingllama
reviewed
Nov 11, 2024
| // app_id refers to the Azure Application ID that supports the SSO for "sso_connector_id". | ||
| // This field is populated on a best-effort basis for legacy plugins but mandatory for plugins created after its introduction. | ||
| // For existing plugins, it is filled in using the entity descriptor url when utilized. | ||
| string app_id = 5; |
There was a problem hiding this comment.
WDYT about azure_app_id ?
There was a problem hiding this comment.
renamed to entra_app_id
codingllama
approved these changes
Nov 11, 2024
flyinghermit
approved these changes
Nov 11, 2024
Comment on lines
+105
to
+108
| Essential *bool `json:"essential,omitempty"` | ||
| Name *string `json:"name,omitempty"` | ||
| Source *string `json:"source,omitempty"` |
There was a problem hiding this comment.
nit: Godoc would be helpful here to understand what kind of data/value are we expecting for each field. For example, what could be the possible value for Source?
tigrato
force-pushed
the
tigrato/entra-id-expose-appid
branch
from
4fc0fa9 to
5a0f3dd
Compare
tigrato
added a commit
that referenced
this pull request
Nov 12, 2024
* [entraid] store entra `appId` in plugin settings This PR stores the Entra ID appID of the application used for SSO in Entra ID plugin settings. This field filled in a best effort scenario and might be empty for old Entra Plugins. Newly created plugins will make the field mandatory. Signed-off-by: Tiago Silva <[email protected]> * handle code review comments --------- Signed-off-by: Tiago Silva <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
* [entraid] store entra `appId` in plugin settings This PR stores the Entra ID appID of the application used for SSO in Entra ID plugin settings. This field filled in a best effort scenario and might be empty for old Entra Plugins. Newly created plugins will make the field mandatory. * handle code review comments --------- Signed-off-by: Tiago Silva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR stores the Entra ID appID of the application used for SSO in Entra ID plugin settings. This field filled in a best effort scenario and might be empty for old Entra Plugins. Newly created plugins will make the field mandatory.