Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] update device type for enrolled/not enrolled #48727

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

stevenGravy
Copy link
Contributor

@stevenGravy stevenGravy commented Nov 9, 2024

The device status is lower case for enrolled and not enrolled. This impacts https://github.com/gravitational/teleport.e/pull/5405 so it uses the right strings.

@stevenGravy stevenGravy added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 9, 2024
@stevenGravy stevenGravy requested a review from avatus November 9, 2024 13:07
@stevenGravy stevenGravy enabled auto-merge November 9, 2024 13:07
Copy link
Contributor

@avatus avatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stevenGravy
Copy link
Contributor Author

https://github.com/gravitational/teleport/pull/48474/files

Why move back to lower case?

The status from device list is enrolled and not enrolled. If we want it upper case it would have to be changed in the display.

@avatus
Copy link
Contributor

avatus commented Nov 9, 2024

Thanks for catching!

@stevenGravy stevenGravy added this pull request to the merge queue Nov 11, 2024
Merged via the queue into master with commit 0511967 Nov 11, 2024
43 checks passed
@stevenGravy stevenGravy deleted the stevenGravy/devicetypes branch November 11, 2024 11:37
@public-teleport-github-review-bot

@stevenGravy See the table below for backport results.

Branch Result
branch/v17 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants