Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve and log endpoints of AWS services #48710

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

rosstimothy
Copy link
Contributor

Includes the AWS endpoints in log output to allow easier inspection of which URIs are being hit based on configuration.

Closes https://github.com/gravitational/customer-sensitive-requests/issues/333.

@rosstimothy rosstimothy added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 8, 2024
@rosstimothy rosstimothy force-pushed the tross/s3_fips branch 2 times, most recently from 844295b to f5dd28b Compare November 12, 2024 16:10
Base automatically changed from tross/s3_fips to master November 12, 2024 17:04
@rosstimothy rosstimothy force-pushed the tross/aws_endpoint_logging branch from a2dd47f to 63c1131 Compare November 12, 2024 17:41
@rosstimothy rosstimothy marked this pull request as ready for review November 12, 2024 18:12
@rosstimothy
Copy link
Contributor Author

FYI @r0mant @capnspacehook

@github-actions github-actions bot added audit-log Issues related to Teleports Audit Log size/sm labels Nov 12, 2024
@rosstimothy rosstimothy added backport/branch/v15 backport/branch/v16 and removed audit-log Issues related to Teleports Audit Log size/sm labels Nov 12, 2024
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tim!

lib/backend/dynamo/dynamodbbk.go Outdated Show resolved Hide resolved
lib/events/s3sessions/s3handler.go Show resolved Hide resolved
@rosstimothy rosstimothy force-pushed the tross/aws_endpoint_logging branch from 7175eb1 to ee59fb6 Compare November 13, 2024 14:24
lib/backend/dynamo/dynamodbbk.go Outdated Show resolved Hide resolved
lib/backend/dynamo/dynamodbbk.go Outdated Show resolved Hide resolved
lib/events/dynamoevents/dynamoevents.go Outdated Show resolved Hide resolved
lib/events/s3sessions/s3handler.go Outdated Show resolved Hide resolved
lib/utils/aws/endpoint/resolver_test.go Outdated Show resolved Hide resolved
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from kiosion November 13, 2024 15:59
Includes the AWS endpoints in log output to allow easier
inspection of which URIs are being hit based on configuration.

Closes gravitational/customer-sensitive-requests#333.
@rosstimothy rosstimothy force-pushed the tross/aws_endpoint_logging branch from 9e4470f to 20895d6 Compare November 13, 2024 16:12
@rosstimothy rosstimothy added this pull request to the merge queue Nov 13, 2024
Merged via the queue into master with commit f84405d Nov 13, 2024
39 checks passed
@rosstimothy rosstimothy deleted the tross/aws_endpoint_logging branch November 13, 2024 16:48
@public-teleport-github-review-bot

@rosstimothy See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants