Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(helm-teleport-cluster): allow to override enterprise license name #48690

Closed
wants to merge 1 commit into from
Closed

feat(helm-teleport-cluster): allow to override enterprise license name #48690

wants to merge 1 commit into from

Conversation

guntiskarulis
Copy link
Contributor

This allows to override hardcoded Kubernetes secret name (i.e. license) for the Enterprise license.

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

hugoShaka
hugoShaka approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@hugoShaka hugoShaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the high quality PR with tests and docs, looks good to me once the only comment is addressed.

examples/chart/teleport-cluster/templates/auth/deployment.yaml Outdated Show resolved Hide resolved
@marcoandredinis marcoandredinis removed their request for review November 11, 2024 09:39
@tigrato tigrato mentioned this pull request Nov 13, 2024
Merged
@tigrato
Copy link
Contributor

tigrato commented Nov 13, 2024

Hi @guntiskarulis,

Thanks for your contribution. We are currently unable to run our tests on
external contributions. As such, I'll be helping you validate and
merge your pull request. I've created an internal PR here:

#48874

Please wait for another approver and I'll get your
code merged. You will retain authorship of your commits.

@tigrato tigrato closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klizhentas klizhentas Awaiting requested review from klizhentas

@mmcallister mmcallister Awaiting requested review from mmcallister

@ptgott ptgott Awaiting requested review from ptgott

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

@hugoShaka hugoShaka Awaiting requested review from hugoShaka

@tigrato tigrato Awaiting requested review from tigrato

Assignees
No one assigned
Labels
documentation helm size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@guntiskarulis @CLAassistant @tigrato @hugoShaka