Machine ID: TBOT_USE_PROXY_ADDR use "yes" vs "1" for consistency #48667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
added
no-changelog
|
I'll manually backport this into the backports for #48373 |
ryanclark
approved these changes
Nov 8, 2024
espadolini
approved these changes
Nov 8, 2024
public-teleport-github-review-bot
bot
removed request for
timothyb89 and
camscale
strideynet
deleted the
strideynet/tbot-use-proxy-addr-env-var-truthy-values
branch
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
…n using TLS routing (#48675) * Machine ID: Support overriding Proxy address from ProxyPing when using TLS routing (#48373) * Start working on ability to use explicit proxy address * Convert more call-sites to use new helper * Convert final callsite * Simplify implementation * Fix teests * Remove additional check * Fix dialling auth client * Update env var name * Machine ID: TBOT_USE_PROXY_ADDR use "yes" vs "1" for consistency (#48667) * Prefer "yes" over "1" for historical consistency * Try and retrigger the CLA check with an empty commit
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 8, 2024
…n using TLS routing (#48677) * Machine ID: Support overriding Proxy address from ProxyPing when using TLS routing (#48373) * Start working on ability to use explicit proxy address * Convert more call-sites to use new helper * Convert final callsite * Simplify implementation * Fix teests * Remove additional check * Fix dialling auth client * Update env var name * Machine ID: TBOT_USE_PROXY_ADDR use "yes" vs "1" for consistency (#48667) * Prefer "yes" over "1" for historical consistency * Try and retrigger the CLA check with an empty commit
smallinsky
pushed a commit
that referenced
this pull request
Nov 12, 2024
…n using TLS routing (#48666) * Start working on ability to use explicit proxy address * Convert more call-sites to use new helper * Convert final callsite * Simplify implementation * Fix teests * Remove additional check * Fix dialling auth client * Update env var name * Machine ID: TBOT_USE_PROXY_ADDR use "yes" vs "1" for consistency (#48667) * Prefer "yes" over "1" for historical consistency * Try and retrigger the CLA check with an empty commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gus rightly pointed out that we tend to use "yes" rather than "1" for truthiness with env var flags.