Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EKS Discover flow fields #48665

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

marcoandredinis
Copy link
Contributor

@marcoandredinis marcoandredinis commented Nov 8, 2024

At a previous PR we added two new fields in the UI and backend, but failed to add them to the layers in between (grpc service).

This PR adds them and also fixes a typo on the EndpointPublicAccess field name.

Previous PR: #48060

Demo:
image

At a previous PR we added two new fields in the UI and backend, but
failed to add them to the layers in between (grpc service).

This PR adds them and also fixes a typo on the EndpointPublicAccess
field name.
@github-actions github-actions bot requested review from gzdunek and ravicious November 8, 2024 11:25
@marcoandredinis marcoandredinis added the test-plan-problem Issues which have been surfaced by running the manual release test plan label Nov 8, 2024
Copy link
Contributor

@kimlisa kimlisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYSM!

@marcoandredinis marcoandredinis added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit 29568bd Nov 8, 2024
48 checks passed
@marcoandredinis marcoandredinis deleted the marco/discover_fix_eks branch November 8, 2024 15:52
@public-teleport-github-review-bot

@marcoandredinis See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Create PR
branch/v17 Create PR

marcoandredinis added a commit that referenced this pull request Nov 8, 2024
At a previous PR we added two new fields in the UI and backend, but
failed to add them to the layers in between (grpc service).

This PR adds them and also fixes a typo on the EndpointPublicAccess
field name.
marcoandredinis added a commit that referenced this pull request Nov 8, 2024
At a previous PR we added two new fields in the UI and backend, but
failed to add them to the layers in between (grpc service).

This PR adds them and also fixes a typo on the EndpointPublicAccess
field name.
github-merge-queue bot pushed a commit that referenced this pull request Nov 8, 2024
At a previous PR we added two new fields in the UI and backend, but
failed to add them to the layers in between (grpc service).

This PR adds them and also fixes a typo on the EndpointPublicAccess
field name.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm test-plan-problem Issues which have been surfaced by running the manual release test plan ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants