-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix EKS Discover flow fields #48665
Merged
Merged
Fix EKS Discover flow fields #48665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At a previous PR we added two new fields in the UI and backend, but failed to add them to the layers in between (grpc service). This PR adds them and also fixes a typo on the EndpointPublicAccess field name.
marcoandredinis
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
backport/branch/v16
backport/branch/v17
labels
Nov 8, 2024
marcoandredinis
added
the
test-plan-problem
Issues which have been surfaced by running the manual release test plan
label
Nov 8, 2024
tigrato
approved these changes
Nov 8, 2024
kimlisa
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TYSM!
public-teleport-github-review-bot
bot
removed request for
ravicious and
gzdunek
November 8, 2024 15:33
@marcoandredinis See the table below for backport results.
|
This was referenced Nov 8, 2024
marcoandredinis
added a commit
that referenced
this pull request
Nov 8, 2024
At a previous PR we added two new fields in the UI and backend, but failed to add them to the layers in between (grpc service). This PR adds them and also fixes a typo on the EndpointPublicAccess field name.
marcoandredinis
added a commit
that referenced
this pull request
Nov 8, 2024
At a previous PR we added two new fields in the UI and backend, but failed to add them to the layers in between (grpc service). This PR adds them and also fixes a typo on the EndpointPublicAccess field name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v15
backport/branch/v16
backport/branch/v17
no-changelog
Indicates that a PR does not require a changelog entry
size/sm
test-plan-problem
Issues which have been surfaced by running the manual release test plan
ui
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At a previous PR we added two new fields in the UI and backend, but failed to add them to the layers in between (grpc service).
This PR adds them and also fixes a typo on the EndpointPublicAccess field name.
Previous PR: #48060
Demo: