Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade buildbox gci to 0.13.5 #48657

Merged
merged 1 commit into from
Nov 10, 2024
Merged

chore: Upgrade buildbox gci to 0.13.5 #48657

merged 1 commit into from
Nov 10, 2024

Conversation

tcsc
Copy link
Contributor

@tcsc tcsc commented Nov 8, 2024

The current verson of GCI in the buildbox treats the Go 1.23 iter package
as an external package rather than part of the stdlib. This patch updates gci
to a version that groups it correctly with other standard library packages.

The current verson of GCI in the buildbox treats the Go 1.23 `iter` package
as an external package rather than part of the stdlib. This patch updates gci
to a version that orders it correctly.
@tcsc tcsc added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 8, 2024
@tcsc tcsc changed the title Upgrade buildbox gci chore: Upgrade buildbox gci to 13.5 Nov 8, 2024
@tcsc tcsc requested a review from camscale November 8, 2024 03:44
@tcsc tcsc changed the title chore: Upgrade buildbox gci to 13.5 chore: Upgrade buildbox gci to 0.13.5 Nov 8, 2024
Copy link
Contributor

@flyinghermit flyinghermit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. GCI linter definitely gave me a headache today trying to merge a PR that imported iter package.

@tcsc tcsc added this pull request to the merge queue Nov 10, 2024
Merged via the queue into master with commit 22d2e0f Nov 10, 2024
42 of 44 checks passed
@tcsc tcsc deleted the tcsc/update-gci branch November 10, 2024 23:38
@public-teleport-github-review-bot

@tcsc See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants