Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Add doc on new field request.kubernetes_resources #48654

Merged
merged 5 commits into from
Nov 15, 2024

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Nov 8, 2024

Backport #48480 to branch/v16

@kimlisa kimlisa added the no-changelog Indicates that a PR does not require a changelog entry label Nov 8, 2024
@github-actions github-actions bot requested review from nklaassen, r0mant and zmb3 November 8, 2024 03:00
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48654.d212ksyjt6y4yg.amplifyapp.com

Copy link

github-actions bot commented Nov 8, 2024

🤖 Vercel preview here: https://docs-pbla5ly8e-goteleport.vercel.app/docs/ver/preview

Copy link
Collaborator

@zmb3 zmb3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the v16 backport I think you should mention the specific v16 version that is required (and I assume that auth and kube agents all need to be on this minimum version for this feature to work).

v16 is pretty far along in its release cycle, so the options mentioned here won't work in the majority of v16 releases. That's a frustrating experience for a user who reads the docs and finds it doesn't work.

@kimlisa kimlisa enabled auto-merge November 13, 2024 18:25
@kimlisa kimlisa disabled auto-merge November 13, 2024 18:25
@@ -406,6 +406,73 @@ Requesting access to a Kubernetes Namespace allows you to access all resources
in that namespace but you won't be able to access any other supported resources
in the cluster.

##### Restrict Access Requests to specific Kubernetes resource kinds

Starting version 16.4.7, the `request.kubernetes_resources` field allows you to restrict what kinds of Kubernetes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion to make it clear that it's just auth services that need to be on 16.4.7

Suggested change
Starting version 16.4.7, the `request.kubernetes_resources` field allows you to restrict what kinds of Kubernetes
<Admonition type="note">
The `request.kubernetes_resources` field was released in Teleport 16.4.7.
All Auth Services must be on version 16.4.7+ before the kubernetes resource restrictions will be enforced.
</Admonition>
The `request.kubernetes_resources` field allows you to restrict what kinds of Kubernetes

Copy link

🤖 Vercel preview here: https://docs-ebnltscmx-goteleport.vercel.app/docs/ver/preview

@kimlisa kimlisa force-pushed the bot/backport-48480-branch/v16 branch from aa80f1d to 9a6e80d Compare November 13, 2024 19:15
Copy link

🤖 Vercel preview here: https://docs-8h6l9ytyi-goteleport.vercel.app/docs/ver/preview

@kimlisa kimlisa force-pushed the bot/backport-48480-branch/v16 branch from 9a6e80d to 4152d46 Compare November 15, 2024 00:55
@kimlisa kimlisa enabled auto-merge November 15, 2024 00:55
Copy link

🤖 Vercel preview here: https://docs-ez4rn4xxf-goteleport.vercel.app/docs/ver/preview

@kimlisa kimlisa added this pull request to the merge queue Nov 15, 2024
Merged via the queue into branch/v16 with commit 332ca14 Nov 15, 2024
41 checks passed
@kimlisa kimlisa deleted the bot/backport-48480-branch/v16 branch November 15, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants