feat: PuTTY PPK support for non-RSA keys #48650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit adds support for Ed25519 and ECDSA keys to PuTTY PPK files generated by tsh. It also adds support for Ed25519 and ECDSA trusted host CAs.
nklaassen
added
no-changelog
webvictim
approved these changes
Nov 8, 2024
|
@webvictim I got a windows laptop recently and I did test this out on my v17 dev cluster, it was working for me, probably don't need you to try it unless you feel like it, thanks for taking a look! |
ravicious
approved these changes
Nov 12, 2024
|
friendly ping @doggydogworld I need one more review on this |
rosstimothy
approved these changes
Nov 12, 2024
public-teleport-github-review-bot
bot
removed the request for review
from doggydogworld
|
@nklaassen See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds support for Ed25519 and ECDSA keys to PuTTY PPK files generated by tsh on Windows. It also adds support for Ed25519 and ECDSA trusted host CAs.