Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: fix pointer events disabling hover badges on integration tiles #48640

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

kimlisa
Copy link
Contributor

@kimlisa kimlisa commented Nov 7, 2024

integration tiles when disabled, will have badges, and on hover have different states:

image image

etc.

setting pointer-events: none, disabled these hover popovers. pointer-events were used to prevent onClicks, but that's now removed in favor of explicitly setting click handlers to undefined if disabled (enterprise change)

also increases the z-index of our react select styled component, before, the header is seen through the dropdown:
image

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48640.d3pp5qlev8mo18.amplifyapp.com

@kimlisa kimlisa added the no-changelog Indicates that a PR does not require a changelog entry label Nov 7, 2024
@kimlisa kimlisa enabled auto-merge November 7, 2024 22:59
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ryanclark November 8, 2024 13:10
@kimlisa kimlisa added this pull request to the merge queue Nov 8, 2024
Merged via the queue into master with commit 0b13107 Nov 8, 2024
41 checks passed
@kimlisa kimlisa deleted the lisa/remove-pointer-events branch November 8, 2024 13:23
@public-teleport-github-review-bot

@kimlisa See the table below for backport results.

Branch Result
branch/v15 Create PR
branch/v16 Create PR
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants