rework ansible-like loadtest helpers #48634
Conversation
fspmarshall
force-pushed
the
fspmarshall/ansible-like-simplification
branch
from
18a1f5d to
bb2d107
Compare
| onboarding: | ||
| join_method: token | ||
| token: ${BOT_TOKEN:?} |
There was a problem hiding this comment.
If we're planning on using AWS, why isn't this IAM?
| echo "installing dumb-init..." >&2 | ||
|
|
||
| sudo wget -q -O /usr/local/bin/dumb-init https://github.com/Yelp/dumb-init/releases/download/v1.2.5/dumb-init_1.2.5_x86_64 | ||
|
|
||
| sudo chmod +x /usr/local/bin/dumb-init |
There was a problem hiding this comment.
dumb-init is just a package on ubuntu - is it not installable in amazon linux?
|
|
||
| cd state | ||
|
|
||
| echo "installing teleport..." >&2 |
There was a problem hiding this comment.
Can we just use the repository or at least the distro packages to install Teleport? We are installing from a real tarball anyway, we should also have the packages.
| path: /opt/machine-id | ||
| storage: | ||
| type: directory | ||
| path: /var/lib/teleport/bot | ||
| services: | ||
| - type: ssh-multiplexer | ||
| destination: | ||
| type: directory | ||
| path: /opt/machine-id |
There was a problem hiding this comment.
We should not be using the same directory for competing outputs, this is very much not supported and will probably break as soon as the wrong ssh_config ends up being used.
| type: directory | ||
| path: /var/lib/teleport/bot |
There was a problem hiding this comment.
With IAM we don't need a storage directory at all, which is sort of a recommended-ish stateless setup AFAIK.
This PR reworks the ansible-like loadtest helpers to be a little easier to work with, and brings them a bit more inline with existing practices elsewhere without substantively changing what they do.
tbot/machineidusage to use the more common pattern of being a general system service that outputs credentials to/opt/machine-id, bringing it more inline with what other tools/helpers/docs use.