Convert github auth code to use x/oauth2 #48598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
the
no-changelog
camscale
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
This all looks fine to me, but I don't know anything about the respective oauth2 packages to say if this is completely correct (i.e. maybe the old package has one default but the new has a different). If there's someone who is familiar with these packages, it would be worth getting them to give it a look-over I think.
rosstimothy
force-pushed
the
tross/github_oauth
branch
from
abc1cd2 to
a009483
Compare
tigrato
approved these changes
Nov 18, 2024
public-teleport-github-review-bot
bot
removed the request for review
from GavinFrazar
Replaces the dependency on go-oidc/oauth2 with x/oauth2 in the github connector auth flows. One result of the switch is that it permitted a lot of simplification - the github client cache used by the auth server was removed entirely.
rosstimothy
force-pushed
the
tross/github_oauth
branch
from
a009483 to
fe74173
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the dependency on go-oidc/oauth2 with x/oauth2 in the github connector auth flows. One result of the switch is that it permitted a lot of simplification - the github client cache used by the auth server was removed entirely.