Prepare to remove go-oidc/oauth2 from config packages #48596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
codingllama
approved these changes
Nov 7, 2024
smallinsky
approved these changes
Nov 7, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kiosion
Adds a OAuthClientCredentials type directly into the servicecfg package so that the dependency on go-oidc/oauth2 can be removed. The PluginOAuthProviders.Slack field has been deprecated, but left in place so as not to break teleport.e and a new PluginOAuthProviders.SlackCredentials field has been added to use the new type. Both fields are being populated with the same data from the file config at the moment. Once teleport.e has been updated to consume the credentials from PluginOAuthProviders.SlackCredentials the original field will be removed.
rosstimothy
force-pushed
the
tross/oauth_client_creds
branch
from
c1cfb68 to
d1464bf
Compare
|
@rosstimothy See the table below for backport results.
|
This was referenced Nov 7, 2024
rosstimothy
added a commit
that referenced
this pull request
Nov 8, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
github-actions bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
rosstimothy
added a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
rosstimothy
added a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 12, 2024
Follow up to #48596 to remove the deprecated field now that gravitational/teleport.e#5373 has removed the last usages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a OAuthClientCredentials type directly into the servicecfg package so that the dependency on go-oidc/oauth2 can be removed. The PluginOAuthProviders.Slack field has been deprecated, but left in place so as not to break teleport.e and a new PluginOAuthProviders.SlackCredentials field has been added to use the new type. Both fields are being populated with the same data from the file config at the moment. Once teleport.e has been updated to consume the credentials from PluginOAuthProviders.SlackCredentials the original field will be removed.