Add ReviewRequests to User ACL #48536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudream
approved these changes
Nov 6, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
kimlisa
approved these changes
Nov 6, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
avatus
force-pushed
the
avatus/fix_topbar_access
branch
from
2e0baf7 to
4a4e929
Compare
avatus
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
public-teleport-github-review-bot
bot
removed request for
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc and
rosstimothy
public-teleport-github-review-bot
bot
removed the request for review
from codingllama
avatus
changed the title
rudream
approved these changes
Nov 8, 2024
|
friendly ping @kimlisa |
This PR exposes `allow.review_requests` capabilities in the user ACL. This is used to conditionally render the "Access Requests" button when feature hiding is on.
avatus
force-pushed
the
avatus/fix_topbar_access
branch
from
4a4e929 to
095c658
Compare
avatus
added
the
no-changelog
This was referenced Nov 12, 2024
avatus
added a commit
that referenced
this pull request
Dec 4, 2024
oss counterpart for gravitational/teleport.e#5628 This adds some testing to the view as well as the equivalent to the web solution for Connect. Connect was missing the [recently added](#48536) `ReviewRequests` field in the user ACL, so I added it here. Because this is handled in the tsh code, we don't have to worry about backward compatibility here for Connect right?
avatus
added a commit
that referenced
this pull request
Dec 5, 2024
oss counterpart for gravitational/teleport.e#5628 This adds some testing to the view as well as the equivalent to the web solution for Connect. Connect was missing the [recently added](#48536) `ReviewRequests` field in the user ACL, so I added it here. Because this is handled in the tsh code, we don't have to worry about backward compatibility here for Connect right?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
oss counterpart for gravitational/teleport.e#5628 This adds some testing to the view as well as the equivalent to the web solution for Connect. Connect was missing the [recently added](#48536) `ReviewRequests` field in the user ACL, so I added it here. Because this is handled in the tsh code, we don't have to worry about backward compatibility here for Connect right?
github-actions bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
oss counterpart for gravitational/teleport.e#5628 This adds some testing to the view as well as the equivalent to the web solution for Connect. Connect was missing the [recently added](#48536) `ReviewRequests` field in the user ACL, so I added it here. Because this is handled in the tsh code, we don't have to worry about backward compatibility here for Connect right?
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 9, 2024
oss counterpart for gravitational/teleport.e#5628 This adds some testing to the view as well as the equivalent to the web solution for Connect. Connect was missing the [recently added](#48536) `ReviewRequests` field in the user ACL, so I added it here. Because this is handled in the tsh code, we don't have to worry about backward compatibility here for Connect right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #46354
This PR exposes
allow.review_requestscapabilities in the user ACL.This is used to conditionally render the "Access Requests" button when
feature hiding is on.
I've added changes to TopBar here even tho its not present in v17 by default, but it will make the backports easier