[teleport-update] Add Makefile build target #48531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vapopov
added
the
no-changelog
sclevine
approved these changes
Nov 6, 2024
rosstimothy
reviewed
Nov 6, 2024
Makefile
Outdated
| @@ -395,6 +395,10 @@ $(BUILDDIR)/tbot: BUILDFLAGS_TBOT += $(if $(TBOT_CGO_FLAGS), -buildmode=pie) | |||
| $(BUILDDIR)/tbot: | |||
| GOOS=$(OS) GOARCH=$(ARCH) $(TBOT_CGO_FLAGS) go build -tags "$(FIPS_TAG) $(KUSTOMIZE_NO_DYNAMIC_PLUGIN)" -o $(BUILDDIR)/tbot $(BUILDFLAGS_TBOT) ./tool/tbot | |||
|
|
|||
| .PHONY: $(BUILDDIR)/teleport-update | |||
| $(BUILDDIR)/teleport-update: | |||
| GOOS=$(OS) GOARCH=$(ARCH) $(CGOFLAG) go build -o $(BUILDDIR)/teleport-update $(BUILDFLAGS) ./tool/teleport-update | |||
There was a problem hiding this comment.
Does this binary require CGO? If not, should we enforce that by always setting CGO_ENABLED=0 here?
rosstimothy
approved these changes
Nov 6, 2024
public-teleport-github-review-bot
bot
removed request for
hugoShaka,
nklaassen and
gzdunek
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR added build target for teleport-update binary