Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update copy in AuthnDialog #48476

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Update copy in AuthnDialog #48476

merged 1 commit into from
Nov 6, 2024

Conversation

avatus
Copy link
Contributor

@avatus avatus commented Nov 5, 2024

This makes the authn dialog make sense in a browser environment and
Teleport Connect
Screenshot 2024-11-05 at 3 09 58 PM

@avatus avatus added backport-required no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 5, 2024
@github-actions github-actions bot requested review from kimlisa and kiosion November 5, 2024 21:11
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48476.d3pp5qlev8mo18.amplifyapp.com

@roraback
Copy link
Contributor

roraback commented Nov 5, 2024

@avatus could you left-align the second line of text, rather than center-aligning it? Looks great otherwise.

This makes the authn dialog make sense in a browser environment and
Teleport Connect
@avatus avatus force-pushed the avatus/authn_dialog branch from 3730a3f to fcfe064 Compare November 5, 2024 22:05
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from kiosion November 6, 2024 00:59
@avatus avatus added this pull request to the merge queue Nov 6, 2024
Merged via the queue into master with commit 779395a Nov 6, 2024
40 checks passed
@avatus avatus deleted the avatus/authn_dialog branch November 6, 2024 15:12
@public-teleport-github-review-bot

@avatus See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 backport-required no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants