Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some issues with the Mac build for ent #48457

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

doggydogworld
Copy link
Contributor

@doggydogworld doggydogworld commented Nov 5, 2024

Overview

The PR for introducing tsh.app and tctl.app to ent packages needs some updates to function correctly. This introduces some more friendly behavior for ent.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48457.d3pp5qlev8mo18.amplifyapp.com

@doggydogworld doggydogworld changed the title Gus/v17 mac package fixes Fixing some issues with the Mac build for ent Nov 5, 2024
@doggydogworld doggydogworld marked this pull request as ready for review November 5, 2024 18:55
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once existing feedback is addressed

@doggydogworld doggydogworld added backport no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Nov 5, 2024
@doggydogworld doggydogworld added this pull request to the merge queue Nov 5, 2024
Merged via the queue into master with commit 4633c48 Nov 5, 2024
40 of 42 checks passed
@doggydogworld doggydogworld deleted the gus/v17-mac-package-fixes branch November 5, 2024 22:00
@public-teleport-github-review-bot

@doggydogworld See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 backport no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants