Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lax "request.kubernetes_resources" field check when querying kube resources #48423

Closed
wants to merge 1 commit into from
Closed

Lax "request.kubernetes_resources" field check when querying kube resources #48423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/services/role.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3317,6 +3317,16 @@ func (set RoleSet) GetAllowedSearchAsRolesForKubeResourceKind(requestedKubeResou
}
}
}

// Look for a role with unconfigured "kubernetes_resources" field,
// which will override configured fields (allow all kinds)
for _, role := range set {
allow := role.GetAccessRequestConditions(types.Allow).KubernetesResources
if len(allow) == 0 {
return set.GetAllowedSearchAsRoles()
}
}

return set.GetAllowedSearchAsRoles(WithAllowedKubernetesResourceKindFilter(requestedKubeResourceKind))
}

Expand Down
27 changes: 20 additions & 7 deletions lib/services/role_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4834,6 +4834,7 @@ func TestGetAllowedSearchAsRoles_WithAllowedKubernetesResourceKindFilter(t *test
}

roleWithNamespace := newRole([]string{"sar1"}, nil, []types.RequestKubernetesResource{{Kind: types.KindNamespace}}, []types.RequestKubernetesResource{})
roleWithAnotherNamespace := newRole([]string{"sar20"}, nil, []types.RequestKubernetesResource{{Kind: types.KindNamespace}}, []types.RequestKubernetesResource{})
roleWithSecret := newRole([]string{"sar2"}, nil, []types.RequestKubernetesResource{{Kind: types.KindKubeSecret}}, []types.RequestKubernetesResource{})
roleWithNoConfigure := newRole([]string{"sar3"}, nil, nil, nil)
roleWithDenyRole := newRole([]string{"sar4", "sar5", "sar6", "sar7"}, []string{"sar4", "sar6"}, []types.RequestKubernetesResource{{Kind: types.KindNamespace}, {Kind: types.KindKubePod}}, []types.RequestKubernetesResource{{Kind: types.KindKubePod}})
Expand All @@ -4846,39 +4847,51 @@ func TestGetAllowedSearchAsRoles_WithAllowedKubernetesResourceKindFilter(t *test
requestType string
expectedAllowedRoles []string
}{
{
name: "no configured field, takes precedence over configured field (allow all kinds)",
roleSet: []types.Role{roleWithNamespace, roleWithNoConfigure},
requestType: types.KindKubeSecret,
expectedAllowedRoles: []string{"sar1", "sar3"},
},
{
name: "no configured field, respects denied field",
roleSet: []types.Role{roleWithNoConfigure, roleWithDenyWildcard},
requestType: types.KindKubeSecret,
expectedAllowedRoles: []string{},
},
{
name: "single match",
roleSet: NewRoleSet(roleWithNamespace, roleWithSecret),
roleSet: []types.Role{roleWithNamespace, roleWithSecret},
requestType: types.KindKubeSecret,
expectedAllowedRoles: []string{"sar2"},
},
{
name: "multi match",
roleSet: NewRoleSet(roleWithNamespace, roleWithNoConfigure),
roleSet: []types.Role{roleWithNamespace, roleWithAnotherNamespace},
requestType: types.KindNamespace,
expectedAllowedRoles: []string{"sar1", "sar3"},
expectedAllowedRoles: []string{"sar1", "sar20"},
},
{
name: "wildcard allow",
roleSet: NewRoleSet(roleWithAllowWildcard, roleWithNamespace),
roleSet: []types.Role{roleWithAllowWildcard, roleWithNamespace},
requestType: types.KindNamespace,
expectedAllowedRoles: []string{"sar1", "sar4", "sar5"},
},
{
name: "wildcard deny",
roleSet: NewRoleSet(roleWithAllowWildcard, roleWithDenyWildcard),
roleSet: []types.Role{roleWithAllowWildcard, roleWithDenyWildcard},
requestType: types.KindNamespace,
expectedAllowedRoles: []string{},
},
{
name: "wildcard deny with unconfigured allow",
roleSet: NewRoleSet(roleWithNoConfigure, roleWithDenyWildcard),
roleSet: []types.Role{roleWithNoConfigure, roleWithDenyWildcard},
requestType: types.KindNamespace,
expectedAllowedRoles: []string{},
},
{
name: "with deny role",
roleSet: NewRoleSet(roleWithDenyRole, roleWithNamespace),
roleSet: []types.Role{roleWithDenyRole, roleWithNamespace},
requestType: types.KindNamespace,
expectedAllowedRoles: []string{"sar5", "sar7", "sar1"},
},
Expand Down
Loading