MatchByOriginAWSIdentityCenterLabel func
#48422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
r0mant
reviewed
Nov 5, 2024
There was a problem hiding this comment.
Does this need to live in OSS repo? Looks like it's only used in https://github.com/gravitational/teleport.e/pull/5332, why not just put it under aws/identitycenter there?
|
Fair enough. I felt such function belongs in the service package. |
|
@flyinghermit I would keep it closer to where it's used as it's IDC specific. There's also an existing precedent with e.g. a similar method used in Okta integration. Plus, one less PR for you to merge and backport. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatchByOriginAWSIdentityCenterLabelis used in Access List reconciler that creates Access List for corresponding identity Center groups.Implemented for https://github.com/gravitational/teleport.e/pull/5332