fix: prevent tctl edit overwriting static file config #48329
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tctl create -f
prevents overwriting thecluster_auth_preference
,cluster_networking_config
, orsession_recording_config
if their configuration is coming from a static config file. Any dynamic edits made to these resources would be overwritten the next time the auth server restarts, so a user trying to edit them usingtctl
is usually making a mistake.tctl create
prevents this mistake unless the user explicitly passes--confirm
which might be useful in some break-glass scenarios.But unfortunately
tctl edit
does nothing to prevent edits to these resources and I have confused myself many times when my config later gets overwritten after a successfultctl edit
. This PR updatestctl edit
to do the same check and require the--confirm
flag to edit any resources configured statically.changelog: Added a warning to
tctl edit
about dynamic edits to statically configured resources