[kube] use local image for kubernetes integration tests #48321

tigrato · 2024-11-01T19:34:53Z

This PR replaces the use of the nginx:latest Docker image in Kubernetes integration tests with a custom-built image based on alpine:3.20.3. This custom image includes a shell for kubectl exec integration tests and a compiled binary to act as an HTTP server.

This change addresses recent issues where test workflows failed due to problems downloading the nginx image.

aws-amplify-us-west-2 · 2024-11-01T19:36:42Z

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48321.d3pp5qlev8mo18.amplifyapp.com

fixtures/alpine/webserver

codingllama · 2024-11-01T21:15:10Z

fixtures/alpine/alpine-3.23.amd64.tar

What is the patch version? Could we get a checksum to go with it too?

Mentioning the source of the image would be nice too.

There's also discrepancy between versions: this file name is 3.23 but the base Docker image is 3.20.3. Typo in this file name?

IMO legal should review this. Including an entire container image worth of OS libraries/tools/external software means that we're now distributing a lot more packages.

IMO legal should review this. Including an entire container image worth of OS libraries/tools/external software means that we're now distributing a lot more packages.

Shouldn't this apply even if we vendored the image in gha container repo?

Not if we used private ECR, then we're only distributing it within the company

But maybe it doesn't matter... are we basing any images off this currently (and therefore have it reviewed/approved already)?

We base only our test images for the Kube integration tests introduced by this PR. Before we relied on pulling these images from docker hub but that often fails and makes our tests extremely flaky when GHA/docker hub has network issues

Is there a way of storing this image in any other private repo and make oss download it?

On d99891f, I sourced the files from alpine cdn and added gpg validation.

integration/kube_integration_test.go

fheinecke

Rather than doing all this, can we configure the workflow to use a pull-through cache in a private ECR registry? Then we don't have to worry about licenses (we won't be redistributing anything), we won't be adding lots of binaries to the repo, and it'll be easier for us to keep up to date.

fixtures/alpine/Dockerfile

fheinecke · 2024-11-01T21:25:51Z

fixtures/alpine/alpine-3.23.amd64.tar

IMO legal should review this. Including an entire container image worth of OS libraries/tools/external software means that we're now distributing a lot more packages.

fixtures/alpine/README.md

Co-authored-by: Alan Parra <[email protected]>

public-teleport-github-review-bot · 2024-11-04T18:38:28Z

@tigrato See the table below for backport results.

Branch	Result
branch/v14	Failed
branch/v15	Failed
branch/v16	Failed
branch/v17	Create PR

* [kube] use local image for kubernetes integration tests This PR replaces the use of the `nginx:latest` Docker image in Kubernetes integration tests with a custom-built image based on `alpine:3.20.3`. This custom image includes a shell for `kubectl exec` integration tests and a compiled binary to act as an HTTP server. This change addresses recent issues where test workflows failed due to problems downloading the `nginx` image. * add information about the image * source files from alpine cdn * copy files from alpine * Update fixtures/alpine/README.md Co-authored-by: Alan Parra <[email protected]> * Update fixtures/alpine/README.md Co-authored-by: Alan Parra <[email protected]> * source files from alpine cdn (again) --------- Co-authored-by: Alan Parra <[email protected]>

) * [kube] use local image for kubernetes integration tests This PR replaces the use of the `nginx:latest` Docker image in Kubernetes integration tests with a custom-built image based on `alpine:3.20.3`. This custom image includes a shell for `kubectl exec` integration tests and a compiled binary to act as an HTTP server. This change addresses recent issues where test workflows failed due to problems downloading the `nginx` image. * add information about the image * source files from alpine cdn * copy files from alpine * Update fixtures/alpine/README.md * Update fixtures/alpine/README.md * source files from alpine cdn (again) --------- Co-authored-by: Alan Parra <[email protected]>

tigrato force-pushed the tigrato/try-fixing-kube-int-tests branch 2 times, most recently from aa65d80 to 6a06d8c Compare November 1, 2024 20:07

tigrato changed the title ~~[kube] initial version using alpine container and self build http server~~ [kube] use local image for kubernetes integration tests Nov 1, 2024

tigrato added backport/branch/v14 no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 backport/branch/v17 labels Nov 1, 2024

tigrato force-pushed the tigrato/try-fixing-kube-int-tests branch 2 times, most recently from a2e56c2 to ee4ddd3 Compare November 1, 2024 20:56

tigrato marked this pull request as ready for review November 1, 2024 21:09

tigrato requested review from klizhentas, russjones, r0mant, zmb3, fheinecke, camscale, tcsc, rosstimothy and codingllama as code owners November 1, 2024 21:09

github-actions bot added the size/sm label Nov 1, 2024

github-actions bot requested review from ravicious and vapopov November 1, 2024 21:09

rosstimothy linked an issue Nov 1, 2024 that may be closed by this pull request

TestKube flakiness #45986

Closed

r0mant reviewed Nov 1, 2024

View reviewed changes

fixtures/alpine/webserver Outdated Show resolved Hide resolved

codingllama reviewed Nov 1, 2024

View reviewed changes

integration/kube_integration_test.go Show resolved Hide resolved

fheinecke reviewed Nov 1, 2024

View reviewed changes

codingllama mentioned this pull request Nov 1, 2024

Bump github.com/charmbracelet/lipgloss from 0.13.0 to 1.0.0 #48277

Merged

codingllama approved these changes Nov 4, 2024

View reviewed changes

fixtures/alpine/README.md Outdated Show resolved Hide resolved

fixtures/alpine/README.md Outdated Show resolved Hide resolved

hugoShaka approved these changes Nov 4, 2024

View reviewed changes

r0mant approved these changes Nov 4, 2024

View reviewed changes

public-teleport-github-review-bot bot removed request for ravicious and vapopov November 4, 2024 17:16

hugoShaka enabled auto-merge November 4, 2024 17:19

hugoShaka disabled auto-merge November 4, 2024 17:21

hugoShaka self-requested a review November 4, 2024 17:24

tigrato and others added 2 commits November 4, 2024 17:27

Update fixtures/alpine/README.md

7e72a79

Co-authored-by: Alan Parra <[email protected]>

Update fixtures/alpine/README.md

7500633

Co-authored-by: Alan Parra <[email protected]>

tigrato enabled auto-merge November 4, 2024 17:27

tigrato disabled auto-merge November 4, 2024 17:35

source files from alpine cdn (again)

cef418e

tigrato enabled auto-merge November 4, 2024 17:54

codingllama approved these changes Nov 4, 2024

View reviewed changes

tigrato added this pull request to the merge queue Nov 4, 2024

Merged via the queue into master with commit 1536d75 Nov 4, 2024
42 checks passed

tigrato deleted the tigrato/try-fixing-kube-int-tests branch November 4, 2024 18:35

tigrato mentioned this pull request Nov 4, 2024

[v17] [kube] use local image for kubernetes integration tests #48382

Merged

This was referenced Nov 4, 2024

[v16] [kube] use local image for kubernetes integration tests #48384

Merged

[v15][kube] use local image for kubernetes integration tests (#48321) #48385

Merged

[v14][kube] use local image for kubernetes integration tests (#48321) #48386

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[kube] use local image for kubernetes integration tests #48321

[kube] use local image for kubernetes integration tests #48321

tigrato commented Nov 1, 2024 •

edited

Loading

aws-amplify-us-west-2 bot commented Nov 1, 2024

codingllama Nov 1, 2024

codingllama Nov 1, 2024

r0mant Nov 1, 2024

fheinecke Nov 1, 2024

tigrato Nov 1, 2024

fheinecke Nov 1, 2024 •

edited

Loading

tigrato Nov 1, 2024 •

edited

Loading

tigrato Nov 4, 2024

fheinecke left a comment

fheinecke Nov 1, 2024

public-teleport-github-review-bot bot commented Nov 4, 2024

[kube] use local image for kubernetes integration tests #48321

[kube] use local image for kubernetes integration tests #48321

Conversation

tigrato commented Nov 1, 2024 • edited Loading

aws-amplify-us-west-2 bot commented Nov 1, 2024

codingllama Nov 1, 2024

Choose a reason for hiding this comment

codingllama Nov 1, 2024

Choose a reason for hiding this comment

r0mant Nov 1, 2024

Choose a reason for hiding this comment

fheinecke Nov 1, 2024

Choose a reason for hiding this comment

tigrato Nov 1, 2024

Choose a reason for hiding this comment

fheinecke Nov 1, 2024 • edited Loading

Choose a reason for hiding this comment

tigrato Nov 1, 2024 • edited Loading

Choose a reason for hiding this comment

tigrato Nov 4, 2024

Choose a reason for hiding this comment

fheinecke left a comment

Choose a reason for hiding this comment

fheinecke Nov 1, 2024

Choose a reason for hiding this comment

public-teleport-github-review-bot bot commented Nov 4, 2024

tigrato commented Nov 1, 2024 •

edited

Loading

fheinecke Nov 1, 2024 •

edited

Loading

tigrato Nov 1, 2024 •

edited

Loading