operator: fix oidc connector max age #48316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
bug
kube-operator
hugoShaka
commented
Nov 1, 2024
Comment on lines
+142
to
+145
| .PHONY: echo-kubebuilder-assets | ||
| echo-kubebuilder-assets: | ||
| @echo KUBEBUILDER_ASSETS=$(shell $(ENVTEST) use $(ENVTEST_K8S_VERSION) -p path) | ||
|
|
There was a problem hiding this comment.
Don't mind this, it's just a helper to get the current kubebuilder assets dir so we can configure the env var properly in the IDE.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
hugoShaka
changed the title
marcoandredinis
approved these changes
Nov 4, 2024
tigrato
approved these changes
Nov 4, 2024
public-teleport-github-review-bot
bot
removed the request for review
from bernardjkim
|
@hugoShaka See the table below for backport results.
|
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixe #48165
This PR deals with the inconsistencies between the CRD and the go types by defining custom marhsaller/unmarshaller on the CR go types.
Tests have also been modified to set the max_age. Without the fix, tests are failing, now they should pass.
Changelog: fix a Teleport Kubernetes Operator bug that happened for OIDCConnector resources with non-nil
max_age.