-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move most of lib/srv/discovery
from logrus to slog
#48292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
backport/branch/v14
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
backport/branch/v16
backport/branch/v17
labels
Nov 1, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rosstimothy
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marco!
marcoandredinis
force-pushed
the
marco/libsrvdiscovery_slog
branch
2 times, most recently
from
November 4, 2024 10:00
bdae4e4
to
3f96b8b
Compare
greedy52
approved these changes
Nov 4, 2024
public-teleport-github-review-bot
bot
removed the request for review
from avatus
November 4, 2024 15:31
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Nov 4, 2024
marcoandredinis
force-pushed
the
marco/libsrvdiscovery_slog
branch
from
November 4, 2024 16:19
3f96b8b
to
7ab0ae0
Compare
@marcoandredinis See the table below for backport results.
|
marcoandredinis
added a commit
that referenced
this pull request
Nov 5, 2024
* Move most of `lib/srv/discovery` from logrus to slog * use local context
marcoandredinis
added a commit
that referenced
this pull request
Nov 5, 2024
* Move most of `lib/srv/discovery` from logrus to slog * use local context
marcoandredinis
added a commit
that referenced
this pull request
Nov 5, 2024
* Move most of `lib/srv/discovery` from logrus to slog * use local context
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Move most of `lib/srv/discovery` from logrus to slog * use local context
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
* Move most of `lib/srv/discovery` from logrus to slog * use local context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v14
backport/branch/v15
backport/branch/v16
backport/branch/v17
discovery
no-changelog
Indicates that a PR does not require a changelog entry
size/sm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.