Fix flaky integration tests caused by prometheus metrics conflict #48248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
flaky tests
no-changelog
hugoShaka
changed the title
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
strideynet
reviewed
Nov 1, 2024
strideynet
approved these changes
Nov 1, 2024
zmb3
approved these changes
Nov 1, 2024
public-teleport-github-review-bot
bot
removed request for
Joerger and
rosstimothy
|
@hugoShaka See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #44944 by overriding the default metrics registry with a blackhole.
This is quite ugly as this override will need to happen on every test running both auth/proxy and tbot in the same process.
The best long-term fix this would be to have tbot use a tbot-scoped registry.