adding missing GID value when fetching Hostuser #48245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
greedy52
reviewed
Oct 31, 2024
integration/hostuser_test.go
Outdated
| t.Cleanup(func() { cleanupUsersAndGroups([]string{testuser}, []string{types.TeleportKeepGroup}) }) | ||
|
|
||
| users := srv.NewHostUsers(context.Background(), presence, "host_uuid") | ||
| expectedHome := filepath.Join("/home", testuser) |
There was a problem hiding this comment.
should we use a temp dir?
There was a problem hiding this comment.
We actually shouldn't be creating a directory at all, this was left over from the test I coped as a base for this one 😅 There's a few tests in here that rely on creating directories in /home that probably need to be updated, so I'll make a note to fix those in a separate PR once I'm finished with v17 testing 👍
eriktate
force-pushed
the
eriktate/48243/fix-unmanaged-user-migration
branch
from
90c42c0 to
0a2c5a6
Compare
rosstimothy
approved these changes
Nov 5, 2024
greedy52
approved these changes
Nov 5, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ryanclark
This was referenced Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48243
This fixes a regression that breaks migrating existing, unmanaged host users to Teleport. The missing value for
GIDwhen fetching aHostUsercauses an error while trying to conver to an int for home directory creation. The migration flow is covered by unit tests, but since this only manifests in the linux backend it wasn't caught. I added a new host user integration test to cover this regression going forward.changelog: Fixed an issue preventing migration of unmanaged users to Teleport host users when including
teleport-keepin a role'shost_groups.