implement autoupdate_agent_rollout reconciler #48241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
added
the
no-changelog
hugoShaka
commented
Oct 31, 2024
espadolini
approved these changes
Nov 4, 2024
|
|
||
| func (h *createUpdateHandler[T]) handle(_ context.Context, object T) (T, error) { | ||
| if len(h.expect) == 0 { | ||
| require.Fail(h.t, "not expecting more calls") |
There was a problem hiding this comment.
Is this guaranteed to be executed in the goroutine running the test? The require helpers will fail the test and then goexit, which won't actually stop the test if it's a goroutine calling the helpers.
There was a problem hiding this comment.
Currently yes, and I don't plan to write multi-goroutine tests if possible. Single-routine tests are easier to await and debug. I'm losing a lot of time because of the async reconciliation in the operator tests and prefer to do everything synchronously + use require.
espadolini
reviewed
Nov 4, 2024
hugoShaka
force-pushed
the
hugo/autoupdate-service-conditional-update
branch
from
21b0779 to
b4e12e5
Compare
vapopov
approved these changes
Nov 4, 2024
sclevine
approved these changes
Nov 4, 2024
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
fspmarshall
Base automatically changed from
hugo/autoupdate-service-conditional-update
to
master
November 4, 2024 18:54
hugoShaka
force-pushed
the
hugo/initial-proxy-agent-update-implementation
branch
from
31e966f to
54f3875
Compare
hugoShaka
force-pushed
the
hugo/initial-proxy-agent-update-implementation
branch
from
97a479d to
3bcb41e
Compare
|
@hugoShaka See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the first implementation of the autoupdate agent rollout reconciler.
The code is not used yet, once this PR is merged I will add a controller that will run every minute in the auth server and calls the reconciler.
Sorry for the large PR (but it's 75% tests I swear 😅 ), I thought it made no sense to send
tryReconcile()without also sendingReconcile()