Fix update and list for DynamicWindowsDesktops #48046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
approved these changes
Oct 29, 2024
api/proto/teleport/dynamicwindows/v1/dynamicwindows_service.proto
Outdated
Show resolved
Hide resolved
flyinghermit
approved these changes
Oct 29, 2024
public-teleport-github-review-bot
bot
removed the request for review
from fspmarshall
Co-authored-by: Zac Bergquist <[email protected]>
|
@probakowski See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
UpsertDynamicWindowsDesktopmethod to the client and uses it intctlcreate command.It also fixes
UpdateDynamicWindowsDesktopto conditionally update resource only if revision matches.It also fixes problem with
ListDynamicWindowsDesktopsand cache