Fix racy X11 forwarding test #48045
Merged
Fix racy X11 forwarding test #48045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
{require,assert}.Eventually run the passed in func on a new goroutine
for each attempt, so it's not safe to write to a shared variable
without any synchronization.
Closes #47756
zmb3
commented
Oct 28, 2024
| @@ -4749,15 +4749,15 @@ func testX11Forwarding(t *testing.T, suite *integrationTestSuite) { | |||
| assert.Eventually(t, func() bool { | |||
| output, err := os.ReadFile(tmpFile.Name()) | |||
| if err == nil && len(output) != 0 { | |||
| display = strings.TrimSpace(string(output)) | |||
| display <- strings.TrimSpace(string(output)) | |||
There was a problem hiding this comment.
I think a buffer of 1 should be okay, since as soon as this write occurs the entire require.EventuallyWithT should complete, but would appreciate more 👀
There was a problem hiding this comment.
Could make it a non-blocking channel write that just discards the value if there's something in the channel already?
Joerger
approved these changes
Oct 28, 2024
espadolini
approved these changes
Oct 29, 2024
public-teleport-github-review-bot
bot
removed the request for review
from capnspacehook
Agreed. |
zmb3
added
the
no-changelog
This was referenced Oct 29, 2024
zmb3
added a commit
that referenced
this pull request
Oct 29, 2024
{require,assert}.Eventually run the passed in func on a new goroutine
for each attempt, so it's not safe to write to a shared variable
without any synchronization.
Closes #47756
This was referenced Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{require,assert}.Eventually run the passed in func on a new goroutine for each attempt, so it's not safe to write to a shared variable without any synchronization.
Closes #47756