Support email plugin status sink #48044
Conversation
bernardjkim
added
access-requests
no-changelog
github-actions
bot
requested review from
hugoShaka,
marcoandredinis and
tigrato
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
|
@bernardjkim See the table below for backport results.
|
| ctx, cancel := context.WithTimeout(req.Context(), statusEmitTimeout) | ||
| defer cancel() | ||
|
|
||
| status := common.StatusFromStatusCode(resp.StatusCode) |
There was a problem hiding this comment.
sorry for the delay. A few months ago, we began adding dedicated status entries for plugins, where we include detailed error information like the error code, a human-readable message, and the original error itself. We’ve implemented this approach for Entra, GitLab, and others.
I suggest doing the same here. A simple "running/not running" status doesn’t provide meaningful insight, especially when running plugins in teleport cloud tenants where users don't have direct access to logs.
Examples of good information:
- can't dial to mailgun
- credentials invalid (expired)
- message rejected...
check
There was a problem hiding this comment.
Hey, that is a good point. The generic "running / not running" status isn't all that helpful. I'll work on a follow up PR soon to improve the status entries.
There was a problem hiding this comment.
Tracking in #48604 so I don't forget
This PR enables the Email plugin to emit its plugin status.
This change is part of the work required to support Teleport-hosted Email plugins.