Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: rbac getting started guide #48029

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from
Draft

docs: rbac getting started guide #48029

wants to merge 11 commits into from

Conversation

mmcallister
Copy link
Contributor

@mmcallister mmcallister commented Oct 28, 2024

Setting up a new PR from rbac guide issue 46417.

Discuss core concepts of user and role #15156, provide simple rbac starter examples  #39241.
Revising existing content, adding an introduction and basics that were missing in the original and how-to guide for setting up RBAC, with additional examples for kubernetes

Closes #40009
Closes #39241

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-48029.d3pp5qlev8mo18.amplifyapp.com

Copy link

🤖 Vercel preview here: https://docs-e6vl89m1b-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-1jx2jhdr5-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-ngh663832-goteleport.vercel.app/docs/ver/preview

@mmcallister
Copy link
Contributor Author

@ptgott could you have a look at this again when you have time? thank you!

docs/pages/admin-guides/access-controls/resource-rbac.mdx Outdated Show resolved Hide resolved
docs/pages/admin-guides/access-controls/resource-rbac.mdx Outdated Show resolved Hide resolved
docs/pages/admin-guides/access-controls/resource-rbac.mdx Outdated Show resolved Hide resolved
Copy link

🤖 Vercel preview here: https://docs-adtlgwln7-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-mfeii42b3-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-ijjmccb0v-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Nov 4, 2024

🤖 Vercel preview here: https://docs-dkwituih5-goteleport.vercel.app/docs/ver/preview

Copy link

github-actions bot commented Nov 5, 2024

🤖 Vercel preview here: https://docs-onobql29z-goteleport.vercel.app/docs/ver/preview

@mmcallister
Copy link
Contributor Author

mmcallister commented Nov 5, 2024

Latest preview link

@ptgott could you have another look when you have some bandwidth? Ty!

@ptgott
Copy link
Contributor

ptgott commented Nov 7, 2024

Hi @mmcallister, what do you think of the comments I left in this thread?

Copy link

github-actions bot commented Nov 8, 2024

🤖 Vercel preview here: https://docs-bb5rm7y6t-goteleport.vercel.app/docs/ver/preview

@mmcallister
Copy link
Contributor Author

Hi @mmcallister, what do you think of the comments I left in this thread?

Grazie @ptgott ! Ok, here's another go. I've used some of the other guides and related blog post for inspiration, e.g. https://goteleport.com/docs/connect-your-client/tsh/, https://goteleport.com/learn/what-is-rbac.

* Edit the Access Controls getting started guide

1. Edit the introduction.

   - Remove unnecessary sentences
   - Move the "What is RBAC" text to the introduction so we describe RBAC
     before saying that this guide shows you how to use it.

2. Move the outline of RBAC components into a "How it works" section.
   This follows the structure of other how-to guides and adds some
   context by using prose.

3. Change the step-by-step instructions.

   - Make these first in the guide to keep with the conventions for our
     step-by-step guides.
   - Add steps to enroll two servers as Docker containers in order to
     demonstrate RBAC.

4. Add conceptual sections under the step-by-step instructions in a
   "Next steps" section. This follows the convention for our how-to
   guides.

   - Reformat "Maintaining your labeling strategy" to make it more
     compact.
   - Edit style in the use cases section to use headings and add a short
     introduction to each code block.

5. Remove the per-resource RBAC section. This section combines Database
   Access Controls and Kubernetes per-resource RBAC. We use
   "per-resource RBAC" to refer to Kubernetes resource RBAC. Instead,
   add a section that links to RBAC-related guides for each kind of
   resource.

* Apply suggestions from code review

Co-authored-by: marie <[email protected]>

---------

Co-authored-by: marie <[email protected]>
Copy link
Contributor

@ptgott ptgott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with suggestions

Comment on lines +9 to +10
:Note:
Please reference [Setting Up Teleport Access Controls for Kubernetes](../../enroll-resources/kubernetes-access/manage-access.mdx) before proceeding, if you have not done so already.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:Note:
Please reference [Setting Up Teleport Access Controls for Kubernetes](../../enroll-resources/kubernetes-access/manage-access.mdx) before proceeding, if you have not done so already.
<Notice type="tip">
Reference [Setting Up Teleport Access Controls for Kubernetes](../../enroll-resources/kubernetes-access/manage-access.mdx) before proceeding, if you have not done so already.
</Notice>
  • Using our docs engine syntax to create a notice
  • Removing "Please", which I don't think we need in technical writing


Below is an example of a role that provides developers with access to only the dev namespace:

```code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
```code
```yaml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use yaml for other YAML examples as well so syntax highlighting works.

Copy link

🤖 Vercel preview here: https://docs-7fuzm6ux5-goteleport.vercel.app/docs/ver/preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking issue] RBAC learning track Provide simple rbac starter example
2 participants