Temporarily remove app label checker for saml_idp_service_provider resources
#48027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flyinghermit
added
the
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
r0mant
approved these changes
Oct 28, 2024
| @@ -1263,6 +1263,11 @@ func (c *resourceAccess) checkAccess(resource types.ResourceWithLabels, filter s | |||
| return false, nil | |||
| } | |||
|
|
|||
| // KindSAMLIdPServiceProvider does not support label matcher | |||
There was a problem hiding this comment.
Let's leave a todo item here to re-enable this when we're ready to properly introduce role v8? And maybe link this PR as a reference.
ravicious
approved these changes
Oct 30, 2024
public-teleport-github-review-bot
bot
removed request for
smallinsky and
camscale
smallinsky
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given pending Role V8 introduction, we cannot rollout app label based RBAC for
saml_idp_service_providerresources in thev17, which otherwise would be a breaking change for customer upgrading tov17. This PR removes theapp_labelchecker forsaml_idp_service_providerresource CRUD methods which were added to theauth_with_rolesmethods.The tests includes app label matcher but expects no error. This is done to ensure that app label are not accidentally introduced/enforced on saml resources.
Manually tested the
saml_idp_service_providerare only enforced with the verbs, as it used to be before enforcingapp_labels