Add a timeout to Lint (Docs) dep installation #47994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For reasons that are unclear, the dependency installation step in the Lint (Docs) GitHub Actions job occasionally takes an indefinite time to complete, and must be canceled manually or after reaching the maximum GitHub Actions runtime. To prevent this situation, this change adds a timeout of 10 minutes to the step that installs NodeJS dependencies for the Lint (Docs) job. This step tends to take around 7 minutes to complete, so a 10-minute timeout should be reasonable.
ptgott
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
hugoShaka
approved these changes
Oct 28, 2024
r0mant
approved these changes
Oct 28, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kopiczko
|
Should we be running the docs lint using an image that already has the right tooling installed instead of spending 7-10 minutes on each run downloading the same stuff? How often do these dependencies change? |
|
@zmb3 We used to build a container image from |
ptgott
added
the
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For reasons that are unclear, the dependency installation step in the Lint (Docs) GitHub Actions job occasionally takes an indefinite time to complete, and must be canceled manually or after reaching the maximum GitHub Actions runtime.
To prevent this situation, this change adds a timeout of 10 minutes to the step that installs NodeJS dependencies for the Lint (Docs) job. This step tends to take around 7 minutes to complete, so a 10-minute timeout should be reasonable.