Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DataTable pagination regression #47990

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

gzdunek
Copy link
Contributor

@gzdunek gzdunek commented Oct 28, 2024

In #47850 I made a silly mistake: "Go to the previous page" actually goes to the next page.

cc @GavinFrazar, thanks for catching this!

@gzdunek gzdunek added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v17 labels Oct 28, 2024
@gzdunek gzdunek requested review from ravicious and bl-nero October 28, 2024 10:18
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47990.d3pp5qlev8mo18.amplifyapp.com

Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding a test.

@gzdunek gzdunek added this pull request to the merge queue Oct 28, 2024
Merged via the queue into master with commit 0e3e4fc Oct 28, 2024
42 checks passed
@gzdunek gzdunek deleted the gzdunek/fix-datatable-navigation branch October 28, 2024 13:11
@public-teleport-github-review-bot

@gzdunek See the table below for backport results.

Branch Result
branch/v17 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants