Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master for v18 #47988

Merged
merged 1 commit into from
Dec 31, 2024
Merged

Update master for v18 #47988

merged 1 commit into from
Dec 31, 2024

Conversation

camscale
Copy link
Contributor

The v17 release branch has been made, so update master so that it refers
to v18.

@camscale camscale added the no-changelog Indicates that a PR does not require a changelog entry label Oct 28, 2024
@camscale camscale requested a review from r0mant October 28, 2024 01:24
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47988.d3pp5qlev8mo18.amplifyapp.com

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from r0mant October 28, 2024 14:59
@fspmarshall
Copy link
Contributor

There's a test failure here being caused by a test I wrote a while back that embedded some hard-coded state from an older version in order to test some migration logic. Consider pulling in c98815d to fix.

@camscale
Copy link
Contributor Author

Consider pulling in c98815d to fix

@fspmarshall I've added that commit to this PR, but it does not fix the integration tests :( (perhaps it did fix one I didn't previously notice, but it was the hsm_test one that I noticed and it still fails for the same reason).

@fspmarshall
Copy link
Contributor

@camscale Yeah, I didn't do a deep dive on all the failures, just fixed the one that was obviously because of a non-standard pattern I'd used in a test.

The v17 release branch has been made, so update master so that it refers
to v18.
@zmb3 zmb3 added this pull request to the merge queue Dec 31, 2024
Merged via the queue into master with commit 909cc20 Dec 31, 2024
43 of 44 checks passed
@zmb3 zmb3 deleted the camh/start-v18 branch December 31, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants