-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update master for v18 #47988
Update master for v18 #47988
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There's a test failure here being caused by a test I wrote a while back that embedded some hard-coded state from an older version in order to test some migration logic. Consider pulling in c98815d to fix. |
2319e96
to
9ae9a60
Compare
@fspmarshall I've added that commit to this PR, but it does not fix the integration tests :( (perhaps it did fix one I didn't previously notice, but it was the hsm_test one that I noticed and it still fails for the same reason). |
@camscale Yeah, I didn't do a deep dive on all the failures, just fixed the one that was obviously because of a non-standard pattern I'd used in a test. |
9ae9a60
to
5f053cd
Compare
The v17 release branch has been made, so update master so that it refers to v18.
9599266
to
b185773
Compare
The v17 release branch has been made, so update master so that it refers
to v18.