Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prototype improved audit log UI #47986

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Prototype improved audit log UI #47986

wants to merge 3 commits into from

Conversation

zmb3
Copy link
Collaborator

@zmb3 zmb3 commented Oct 27, 2024

Proof of concept for a new approach that @roraback and I were brainstorming to get rid of the large amount of square brackets in the audit log UI.

Before:

image

After:

image

The intent is that we would use the "icon + bold text" approach on anything we want to highlight (users, resources, etc)

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47986.d3pp5qlev8mo18.amplifyapp.com

@zmb3 zmb3 force-pushed the zmb3/audit-log-ui branch 2 times, most recently from dcae22b to 7e05f35 Compare November 1, 2024 17:43
Comment on lines 795 to 659
if (user) {
return (
<Box>
<User user={user} /> requested an MFA authentication challenge
</Box>
);
} else {
return <>Passwordless user requested an MFA authentication challenge</>;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
if (user) {
return (
<Box>
<User user={user} /> requested an MFA authentication challenge
</Box>
);
} else {
return <>Passwordless user requested an MFA authentication challenge</>;
}
if (user) {
return (
<Box>
<User user={user} /> requested an MFA authentication challenge
</Box>
);
}
return <>Passwordless user requested an MFA authentication challenge</>;

@zmb3 zmb3 force-pushed the zmb3/audit-log-ui branch from ba1aace to d91a6f7 Compare November 28, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants