-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prototype improved audit log UI #47986
Draft
zmb3
wants to merge
3
commits into
master
Choose a base branch
from
zmb3/audit-log-ui
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
force-pushed
the
zmb3/audit-log-ui
branch
2 times, most recently
from
November 1, 2024 17:43
dcae22b
to
7e05f35
Compare
kimlisa
force-pushed
the
zmb3/audit-log-ui
branch
from
November 1, 2024 19:06
31a2651
to
ba1aace
Compare
kimlisa
approved these changes
Nov 1, 2024
ryanclark
approved these changes
Nov 5, 2024
Comment on lines
795
to
659
if (user) { | ||
return ( | ||
<Box> | ||
<User user={user} /> requested an MFA authentication challenge | ||
</Box> | ||
); | ||
} else { | ||
return <>Passwordless user requested an MFA authentication challenge</>; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
Suggested change
if (user) { | |
return ( | |
<Box> | |
<User user={user} /> requested an MFA authentication challenge | |
</Box> | |
); | |
} else { | |
return <>Passwordless user requested an MFA authentication challenge</>; | |
} | |
if (user) { | |
return ( | |
<Box> | |
<User user={user} /> requested an MFA authentication challenge | |
</Box> | |
); | |
} | |
return <>Passwordless user requested an MFA authentication challenge</>; |
zmb3
force-pushed
the
zmb3/audit-log-ui
branch
from
November 28, 2024 15:56
ba1aace
to
d91a6f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proof of concept for a new approach that @roraback and I were brainstorming to get rid of the large amount of square brackets in the audit log UI.
Before:
After:
The intent is that we would use the "icon + bold text" approach on anything we want to highlight (users, resources, etc)