Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Vale spelling rule #47970

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Oct 25, 2024

Closes #46191

This change adds a Vale spelling rule that replaces the current cspell workflow. The Vale spelling rule ignores spelling errors in code-style text by default, and includes more configuration options for filtering spelling errors. This also allows us to reduce the number of linting workflows.

This change also adds a file containing words to ignore in the spellcheck rule, based on the current cspell.json.

While this change introduces new spelling errors, we can remove these incrementally, since the Vale spellchecker only flags issues in files changed by a PR.

This change also configures the Vale spellcheck rule to ignore abbreviations.

For consistency with the cspell configuration, this change ignores spelling errors in Terraform and Kubernetes operator reference pages. To do so, it adds the {/* vale spelling.spelling = OFF */} comment directive in relevant auto-generated reference pages.

@ptgott
Copy link
Contributor Author

ptgott commented Oct 25, 2024

This PR depends on #47907, so I am putting it in draft.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47970.d3pp5qlev8mo18.amplifyapp.com

Copy link

🤖 Vercel preview here: https://docs-mfl1gspkw-goteleport.vercel.app/docs/ver/preview

Copy link

🤖 Vercel preview here: https://docs-4aipi6b3c-goteleport.vercel.app/docs/ver/preview

Closes #46191

This change adds a Vale spelling rule that replaces the current cspell
workflow. The Vale spelling rule ignores spelling errors in code-style
text by default, and includes more configuration options for filtering
spelling errors. This also allows us to reduce the number of linting
workflows.

This change also adds a file containing words to ignore in the
spellcheck rule, based on the current `cspell.json`.

While this change introduces new spelling errors, we can remove these
incrementally, since the Vale spellchecker only flags issues in files
changed by a PR.

This change also configures the Vale spellcheck rule to ignore
abbreviations.

For consistency with the cspell configuration, this change ignores
spelling errors in Terraform and Kubernetes operator reference pages. To
do so, it adds the `{/* vale spelling.spelling = OFF */}` comment
directive in relevant auto-generated reference pages.
@ptgott ptgott force-pushed the paul.gottschling/46191-spelling branch from a52ff2d to de0631b Compare December 18, 2024 19:39
Copy link

🤖 Vercel preview here: https://docs-a3ts75xvh-goteleport.vercel.app/docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore code in the spellcheck workflow
1 participant