Update depgaurd rules to prevent logrus from being imported in e #47962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
rosstimothy
force-pushed
the
tross/prevent_logrus_in_e
branch
3 times, most recently
from
3ab89b3 to
8971f94
Compare
rosstimothy
commented
Oct 25, 2024
| _ "github.com/aws/aws-sdk-go-v2/service/sts" | ||
| _ "github.com/aws/aws-sdk-go-v2/service/sts/types" | ||
| _ "github.com/beevik/etree" | ||
| _ "github.com/cloudflare/cfssl/csr" |
There was a problem hiding this comment.
It looks like this slipped in for some license related tests. I'm working on removing and will follow up with another PR once it's no longer needed.
rosstimothy
force-pushed
the
tross/prevent_logrus_in_e
branch
from
8971f94 to
43148e3
Compare
The teleport.e repo was recently converted to log exclusively with slog. In order to prevent logrus from accidentally being reintroduced into teleport.e the logrus depguard rule was updated to include the e repo. Additionally the e_imports.go file was updated to reflect that logrus is no longer required.
rosstimothy
force-pushed
the
tross/prevent_logrus_in_e
branch
from
43148e3 to
60f2611
Compare
github-actions
bot
requested review from
hugoShaka,
marcoandredinis and
tigrato
rosstimothy
added
the
no-changelog
greedy52
approved these changes
Oct 25, 2024
hugoShaka
approved these changes
Oct 25, 2024
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
tigrato
espadolini
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The teleport.e repo was recently converted to log exclusively with slog. In order to prevent logrus from accidentally being reintroduced into teleport.e the logrus depguard rule was updated to include the e repo. Additionally the e_imports.go file was updated to reflect that logrus is no longer required.