Discover EKS: handle 'CONFIG_MAP' authentication mode gracefully #47960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
marcoandredinis
force-pushed
the
marco/discover_eksenrollcluster_handle_configmap_auth
branch
from
5d8f3df to
0d656ce
Compare
|
@fspmarshall @mvbrock Can you please take a look when you get a chance? |
fspmarshall
approved these changes
Oct 29, 2024
marcoandredinis
force-pushed
the
marco/discover_eksenrollcluster_handle_configmap_auth
branch
from
0d656ce to
1992185
Compare
tigrato
reviewed
Nov 1, 2024
tigrato
approved these changes
Nov 1, 2024
public-teleport-github-review-bot
bot
removed the request for review
from mvbrock
EKS Cluster Access Config's Authentication mode can be set to one of: - API - API_AND_CONFIG_MAP - CONFIG_MAP Teleport requires either API or API_AND_CONFIG_MAP to install the helm chart. This PR checks this value before trying to install the helm chart. This way the user is presented with a better error message.
marcoandredinis
force-pushed
the
marco/discover_eksenrollcluster_handle_configmap_auth
branch
from
1992185 to
b025b16
Compare
marcoandredinis
deleted the
marco/discover_eksenrollcluster_handle_configmap_auth
branch
|
@marcoandredinis See the table below for backport results.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EKS Cluster Access Config's Authentication mode can be set to one of:
Teleport requires either API or API_AND_CONFIG_MAP to install the helm chart.
This PR checks this value before trying to install the helm chart. This way the user is presented with a better error message.