Add user type (local or sso) to tlsca.Identity #47946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoandredinis
added
backport/branch/v14
no-changelog
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
zmb3
reviewed
Oct 28, 2024
Even tho the field was there, it was not being set when converting to/from pkix.Name. This PR adds a new extension and sets the value when converting.
marcoandredinis
force-pushed
the
marco/include_usertype_identity
branch
from
76f5e6f to
00681b9
Compare
zmb3
approved these changes
Oct 28, 2024
marcoandredinis
force-pushed
the
marco/include_usertype_identity
branch
from
00681b9 to
0231bfb
Compare
|
@rudream Can you please take a look when you get a chance? |
tigrato
approved these changes
Nov 6, 2024
public-teleport-github-review-bot
bot
removed the request for review
from rudream
|
@marcoandredinis See the table below for backport results.
|
This was referenced Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even tho the field was there, it was not being set when converting to/from pkix.Name.
This PR adds a new extension and sets the value when converting.