Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeout for auto update integration tests #47928

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

vapopov
Copy link
Contributor

@vapopov vapopov commented Oct 25, 2024

In this PR extended timeout for integration autoupdate test TestUpdate mentioned in #47915
Average CI/CD execution time of TestUpdate right now is ~29sec, which might easily exceed current timeout in 30sec

-race flag adds a lot of overhead for this specific tests, in local run difference

=== RUN   TestUpdate
2024/10/25 03:55:00 Calculating and serving file checksum: /tmp/updater4001372424/teleport-v1.2.3-linux-arm64-bin.tar.gz
Update progress: [▒▒▒▒▒▒▒▒▒▒] (Ctrl-C to cancel update)
2024/10/25 03:55:01 Calculating and serving file checksum: /tmp/updater4001372424/teleport-v3.2.1-linux-arm64-bin.tar.gz
--- PASS: TestUpdate (2.14s)

with -race flag:

=== RUN   TestUpdate
2024/10/25 03:59:55 Calculating and serving file checksum: /tmp/updater2983531478/teleport-v1.2.3-linux-arm64-bin.tar.gz
Update progress: [▒▒▒▒▒▒▒▒▒▒] (Ctrl-C to cancel update)
2024/10/25 04:00:14 Calculating and serving file checksum: /tmp/updater2983531478/teleport-v3.2.1-linux-arm64-bin.tar.gz
--- PASS: TestUpdate (19.52s)

Results of running go test . -v -count 300 -race -timeout 0

PASS
ok  	github.com/gravitational/teleport/integration/autoupdate/tools	17350.623s

@vapopov vapopov requested a review from nklaassen October 25, 2024 04:10
@vapopov vapopov added the no-changelog Indicates that a PR does not require a changelog entry label Oct 25, 2024
@github-actions github-actions bot requested review from rudream and zmb3 October 25, 2024 04:10
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47928.d212ksyjt6y4yg.amplifyapp.com

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47928.d3pp5qlev8mo18.amplifyapp.com

@vapopov vapopov requested review from hugoShaka and sclevine October 25, 2024 12:57
@vapopov vapopov added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit 458a32a Oct 25, 2024
40 checks passed
@vapopov vapopov deleted the vapopov/fix-flaky-test-autoupdate-tools branch October 25, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants