Fix linter errors introduced by #47841 #47913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a few non-Linux lints introduced in #47841, where staticcheck complains about noop implementations for non-Linux OSes. It also removes an outdated TODO comment.
rosstimothy
approved these changes
Oct 24, 2024
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
timothyb89
added
the
no-changelog
zmb3
approved these changes
Oct 24, 2024
public-teleport-github-review-bot
bot
removed request for
marcoandredinis and
strideynet
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
tigrato
approved these changes
Oct 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a few non-Linux lints introduced in #47841, where staticcheck complains about noop implementations for non-Linux OSes. It required 4 individual exemptions in a single small function (!) so I just added it at the function level.
It also removes an outdated TODO comment.