Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rdpclient: remove static_init dependency #47911

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

espadolini
Copy link
Contributor

This PR removes the dependency on static_init in favor of the stdlib's own std::sync::LazyLock and a manual function call at go init time.

@espadolini espadolini added the no-changelog Indicates that a PR does not require a changelog entry label Oct 24, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47911.d212ksyjt6y4yg.amplifyapp.com

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47911.d3pp5qlev8mo18.amplifyapp.com

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from probakowski October 25, 2024 16:14
@espadolini espadolini added this pull request to the merge queue Oct 25, 2024
Merged via the queue into master with commit d288736 Oct 25, 2024
43 checks passed
@espadolini espadolini deleted the espadolini/rdpclient-no-staticinit branch October 25, 2024 16:33
@public-teleport-github-review-bot

@espadolini See the table below for backport results.

Branch Result
branch/v15 Failed
branch/v16 Failed

@espadolini
Copy link
Contributor Author

Not backporting because v16 and v15 have too old of a rust toolchain version (std::sync::LazyLock was stabilized in 1.80.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop-access no-changelog Indicates that a PR does not require a changelog entry rdp size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants